Skip to content

chore(SkeletonBox): promote to Alpha #5693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 2, 2025
Merged

chore(SkeletonBox): promote to Alpha #5693

merged 12 commits into from
Apr 2, 2025

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Feb 13, 2025 •
edited
Loading

Closes https://github.com/github/primer/issues/4682

Promotes SkeletonBox component to Alpha

Changelog

Changed

  • Move SkeletonBox outside of the experimental and into its own folder
  • Change SkeletonBox status from 'draft' to 'alpha'
  • Update components that used SkeletonBox's sx prop to use css modules instead
  • update exports

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 05970ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Feb 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot requested a deployment to storybook-preview-5693 February 13, 2025 01:12 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5693 February 13, 2025 01:26 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-5693 April 2, 2025 01:37 Abandoned
@francinelucca francinelucca changed the title WIP: chore(SkeletonBox): promote to Alpha chore(SkeletonBox): promote to Alpha Apr 2, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-5693 April 2, 2025 01:44 Abandoned
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 106.02 KB (-0.02% 🔽)
packages/react/dist/browser.umd.js 106.37 KB (+0.08% 🔺)

@github-actions github-actions bot requested a deployment to storybook-preview-5693 April 2, 2025 01:49 Abandoned
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/370753

@github-actions github-actions bot requested a deployment to storybook-preview-5693 April 2, 2025 01:52 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5693 April 2, 2025 02:07 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 2, 2025
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Apr 2, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@francinelucca francinelucca mentioned this pull request Apr 2, 2025
Closed
13 tasks
@github-actions github-actions bot temporarily deployed to storybook-preview-5693 April 2, 2025 03:26 Inactive
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 2, 2025
@francinelucca francinelucca marked this pull request as ready for review April 2, 2025 03:51
@francinelucca francinelucca requested a review from a team as a code owner April 2, 2025 03:51
@francinelucca francinelucca requested a review from jonrohan April 2, 2025 03:51
@francinelucca francinelucca added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit da85192 Apr 2, 2025
44 checks passed
@francinelucca francinelucca deleted the chore/promote-skeleton-box-to-alpha branch April 2, 2025 13:49
@primer primer bot mentioned this pull request Apr 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member update snapshots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francinelucca @jonrohan